-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Develop updated getting started page #2059
Develop updated getting started page #2059
Conversation
…ating new look of getting-started page
From your project repository, check out a new branch and test the changes.
|
…ttribution. also changed accordion arrows to one uniform pink color for both desktop and mobile views
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far! I've requested a few changes.
I also found the header svgs get a little stretched out when testing for tablet. This may have to do with their set height, and could be fixed with a media query.
Edit: Ugh. I didn't save my comments before submitting... Adding those changes now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far. Please see below for my comments:
-
I agree with Sarah. I got the same result for the header svgs when I tested the tablet. With that, replacing the
height
withmax-width
andmax-height
in .step-img-intro may resolve the issue. -
The icon in Step 2 looks faded/orange (both on desktop and mobile) compared to what we have in the Figma file. Is this what we want our icon to look?
@aalieu Replace the Step 2 image (.png) so it matches the Figma file. @arghmatey will create separate styling issues for the page (created #2193) As soon as the image is replaced, we will be able to merge this pull request. Thank you. |
Thank you so much for your reviews! Hey Adam, sorry but I will be out of town until the 29th so I won't be able to update my PR until right before the Tuesday meeting on the 31st. There's a slight problem though with replacing the step 2 image — I got the icon straight from the links provided in Figma so I'm not sure why it looks faded and orange. I'm not sure what can be done about it since it's an icon from another source. This is the link for the icon where it is faded and orange compared to Figma: https://www.freepik.com/free-vector/solidarity-concept-illustration_14562369.htm#page=5&position=24 |
@aalieu There seems to be a miscommunication. You can download images directly from the Figma design. You will have to rename the file, but you will get the png with the proper color. |
Awesome, thanks for the clarification! Thanks for the step-by-step instruction too. I had no idea that you could export images from Figma so I definitely learned something new and useful today. |
… to faq font weight and info icon sizing
Changed the step 2 image to the correct version. Also resolved the changes requested by @alyssabenipayo and @arghmatey. Should be ready to merge @abuna1985! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Fixes #1619
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied